Dashboard

Rettelsen er en pull request. Polylane skriver den, du merger den.

Skriv dig på ventelisten
github.com/coreplane/payments-api/pull/491

Cap retries on the checkout webhook worker #491

polylane
Open polylane wants to merge 1 commit into main from polylane/autofix/chat/k3x9f2-4e7d21a
Conversation 1 Commits 1 Checks 1 Files changed 2
polylane bot commented 6 minutes ago ···

Retries on the checkout webhook worker were unbounded: a failing delivery re-queued itself forever and amplified load on payments-api. This caps delivery at 5 attempts with exponential backoff and dead-letters the payload after the last one.

What changed

worker/deliver.ts gains MAX_DELIVERY_ATTEMPTS = 5 and backoff between attempts; exhausted payloads land in checkout-webhooks-dlq instead of re-queueing.

Validation

npm test — 214 passed. A forced failing delivery stopped after 5 attempts and appeared in the dead-letter queue.

Root cause · Why it's safe · Out of scope
polylane added commit 4e7d21a Verified
Review required At least 1 approving review is required
ci / test Successful in 3m 12s Details
Review required Waiting on your review: Polylane never merges on its own
Merging is blocked

En rettelse, du ikke behøvede skrive. Og grunde til at stole på den.

  • Skrevet som en kollega ville

    I en sandbox, på en branch, efter dine commit-konventioner og dit repositorys instruktioner.

  • Kontrolleret, før den åbnes

    En sikkerhedsgennemgang leder efter de måder, en korrekt diff stadig kan bryde et deploy: låsende migreringer, brud ved blandede versioner.

  • Stopper ved din gennemgang

    Din gennemgang og din CI afgør mergen, punktum.

  • Den lærer af et nej

    Luk pull requesten uden at merge, og Polylane finder ud af hvorfor og gentager det ikke.

Din gennemgang er merge-knappen. Polylane merger aldrig på egen hånd.