Dashboard

"At merge denne pull request kan forringe produktion." Polylane gennemgår hver pull request mod den levende produktion.

Skriv dig på ventelisten
github.com/coreplane/orders-api/pull/482

Add trigram index for order search #482

Open rvidal wants to merge 1 commit into main from order-search-trgm
Conversation 1 Commits 1 Checks 2 Files changed 1
polylane bot commented 2 minutes ago ···
Caution

Merging this pull request may degrade production (high impact).

Merging this blocks every write to orders while the index builds. migrations/0114_order_search_trgm.sql:3 adds CREATE INDEX … USING gin (search_text gin_trgm_ops) without CONCURRENTLY, and a plain CREATE INDEX takes a full write lock on orders for the whole build. Checkout sustains ~38 writes/s on that table; each one queues behind the lock until the build finishes.

To make this safe: build the index with CREATE INDEX CONCURRENTLY outside the transactional migration.

orders-db · writes per second · last 48h projected lock window
02040
-48h -24h now
every one of these writes blocks while the index builds

Polylane analysed de91b47 for production impact.

Some checks were not successful 1 failing and 1 successful check
ci / test Successful in 2m 4s Details
Polylane production impact Non-concurrent index build locks writes on orders Details
Merging is blocked

Din linter kan ikke se produktion. Det kan denne reviewer.

  • Gennemgået mod det, der kører

    Diffen kontrolleres mod de services, den deployer til: deres konfiguration, deres trafik, deres seneste hændelser.

  • Godkendt som standard

    Et afvist skal bevise præcis, hvordan en linje i diffen bryder produktion. "Måske" tæller ikke.

  • Én kommentar

    Opdateret på stedet ved hvert push, aldrig en bunke. Ændringer i docs og tests går lige igennem.

  • Tænder, hvis du vil have dem

    Slå den blokerende kontrol til, og et afvist holder mergen tilbage, indtil et senere push løser det.

Den billigste hændelse er den, der aldrig bliver merget. Polylane fanger den i gennemgangen.

Skriv dig på ventelisten