polylane

“Merging this pull request may degrade production.” Polylane reviews every pull request against live production.

Join the waitlist
github.com/coreplane/orders-api/pull/482

Add trigram index for order search #482

Open rvidal wants to merge 1 commit into main from order-search-trgm
Conversation 1 Commits 1 Checks 2 Files changed 1
polylane bot commented 2 minutes ago ···
Caution

Merging this pull request may degrade production (high impact).

Merging this blocks every write to orders while the index builds. migrations/0114_order_search_trgm.sql:3 adds CREATE INDEX … USING gin (search_text gin_trgm_ops) without CONCURRENTLY, and a plain CREATE INDEX takes a full write lock on orders for the whole build. Checkout sustains ~38 writes/s on that table; each one queues behind the lock until the build finishes.

To make this safe: build the index with CREATE INDEX CONCURRENTLY outside the transactional migration.

orders-db · writes per second · last 48h projected lock window
02040
-48h -24h now
every one of these writes blocks while the index builds

Polylane analysed de91b47 for production impact.

Some checks were not successful 1 failing and 1 successful check
ci / test Successful in 2m 4s Details
Polylane production impact Non-concurrent index build locks writes on orders Details
Merging is blocked

Your linter can't see production. This reviewer can.

  • Reviewed against what's live

    The diff is checked against the services it deploys to: their config, their traffic, their recent incidents.

  • Pass by default

    A fail has to prove exactly how a line in the diff breaks production. “Might” doesn't count.

  • One comment

    Updated in place on every push, never a pile-on. Docs and test changes pass straight through.

  • Teeth, if you want them

    Turn on the blocking check and a fail holds the merge until a later push resolves it.

The cheapest incident is the one that never merges. Polylane catches it in review.

Join the waitlist